Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config spec, make the values of optional parameters more explicit #216

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Update config spec, make the values of optional parameters more explicit #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ballista/rust/executor/executor_config_spec.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ doc = "Max concurrent tasks."
abbr = "s"
name = "task_scheduling_policy"
type = "ballista_core::config::TaskSchedulingPolicy"
doc = "The task scheduing policy for the scheduler, see TaskSchedulingPolicy::variants() for options. Default: PullStaged"
doc = "The task scheduing policy for the scheduler, possible values: pull-staged, push-staged. Default: pull-staged"
default = "ballista_core::config::TaskSchedulingPolicy::PullStaged"

[[param]]
Expand Down Expand Up @@ -119,4 +119,3 @@ name = "log_level_setting"
type = "String"
doc = "special log level for sub mod. link: https://docs.rs/env_logger/latest/env_logger/#enabling-logging. For example we want whole level is INFO but datafusion mode is DEBUG"
default = "std::string::String::from(\"INFO,datafusion=INFO\")"

4 changes: 2 additions & 2 deletions ballista/rust/scheduler/scheduler_config_spec.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ doc = "Print version of this executable"
abbr = "b"
name = "config_backend"
type = "ballista_scheduler::state::backend::StateBackend"
doc = "The configuration backend for the scheduler, see StateBackend::variants() for options. Default: Standalone"
doc = "The configuration backend for the scheduler, possible values: etcd, standalone. Default: standalone"
default = "ballista_scheduler::state::backend::StateBackend::Standalone"

[[param]]
Expand Down Expand Up @@ -69,7 +69,7 @@ doc = "bind port. Default: 50050"
abbr = "s"
name = "scheduler_policy"
type = "ballista_core::config::TaskSchedulingPolicy"
doc = "The scheduing policy for the scheduler, see TaskSchedulingPolicy::variants() for options. Default: PullStaged"
doc = "The scheduing policy for the scheduler, possible values: pull-staged, push-staged. Default: pull-staged"
default = "ballista_core::config::TaskSchedulingPolicy::PullStaged"

[[param]]
Expand Down