Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI to prevent future breaking of FlightSql #191

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #190.

Rationale for this change

It would be good if CI could prevent features from breaking in the future.

What changes are included in this PR?

  1. Fix the build for the flight-sql feature
  2. Update CI to run tests with that feature flag active

Are there any user-facing changes?

FlightSQL should work again and stay working.

@yahoNanJing
Copy link
Contributor

LGTM

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit ac7dbe3 into apache:master Sep 6, 2022
@avantgardnerio avantgardnerio deleted the bg_fix_flightsql branch September 6, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlightSQL is broken and CI isn't catching it
3 participants