fix(iOS): #257 #290
Open
fix(iOS): #257 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
fix #257
Description
Desynchronize
isLocationServicesEnabledAs comment, this change might cause some problems because of run in thread that location manager is not created in. Especially, around this line (change updating location status and accuracy) are suspecious. But I have no idea that critical situation that incorrect behavior that caller JS application cannot (or should not) handle.
If there are some problems about above, I will close this PR. If there are no problem, I will remove TODO comment before you marge.
Testing
I did simple operation confirmation with simulator.
Checklist
(platform)if this change only applies to one platform (e.g.(android))