Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove deprecated platforms #270

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix!: remove deprecated platforms #270

merged 2 commits into from
Aug 31, 2020

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Aug 26, 2020 •
edited
Loading

Platforms affected

  • Amazon Fire OS
  • Blackberry 10
  • Windows Phone
  • Firefox OS
  • Windows 8

Motivation and Context

Maintain only active platforms.

Description

Removes deprecated platforms.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

erisu
erisu reviewed Aug 26, 2020
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the comments...

I am not super familiar with the existing supported windows platform but I think they can still be installed on phones.

If that is correct, then I think some of the follow needs to stay but changed slightly.

@timbru31 timbru31 linked an issue Aug 28, 2020 that may be closed by this pull request
Remove support for deprecated platforms #214
Closed
@timbru31 timbru31 closed this Aug 31, 2020
@timbru31 timbru31 reopened this Aug 31, 2020
@timbru31 timbru31 requested a review from erisu August 31, 2020 10:55
@timbru31 timbru31 merged commit 46666ee into master Aug 31, 2020
@timbru31 timbru31 deleted the fix/platforms branch August 31, 2020 14:02
MayankLogiciel added a commit to MayankLogiciel/cordova-plugin-file-transfer that referenced this pull request Oct 5, 2020
@MayankLogiciel @janpio
@timbru31 @erisu @breautek
Updated Repo for using updated plugin. (#1)
072508d 
* Add or update GitHub pull request and issue template
* docs: undeprecate the plugin (apache#267)
Co-authored-by: エリス <[email protected]>
* fix(ios): re-implement user agent overwrite (apache#268)
This closes apache#263 apache#258
* chore(npm): adds ignore list (apache#269)
* fix!: remove deprecated platforms (apache#270)
* chore: bump version to 2.0.0-dev (apache#273)
* chore: package cleanup (apache#272)
* refactor(eslint): use cordova-eslint /w fix (apache#275)
* chore: adds package-lock file (apache#274)
* doc: Improve progressEvent documentation (apache#280)

Co-authored-by: Jan Piotrowski <[email protected]>
Co-authored-by: Tim Brust <[email protected]>
Co-authored-by: エリス <[email protected]>
Co-authored-by: Norman Breau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for deprecated platforms
2 participants
@timbru31 @erisu