Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Fix js error 'The parameter is incorrect' for upload #229

Closed
wants to merge 1 commit into from

Conversation

PabbleDabble
Copy link

@PabbleDabble PabbleDabble commented Mar 7, 2019

Platforms affected

Windows

Motivation and Context

There was a similar PR recenly - #199 - that fixed this error for Windows on the download portion of the code.
I was testing this plugin, trying to upload files, and our directory was set as read only to test failing the download. An unhandled exception would be thrown and crash our Windows app. This is a catch for that exception.

Description

When upload.progress.bytesReceived is 0, this fix will catch that case very similar to the download fix, and resolve an error and stop the function.

Testing

Manual testing - Loaded our app with my changed version of the plugin installed. The download still failed, as intended to a read only directory, but the app did not crash, and our file upload call was able to receive the 500 error.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@PabbleDabble PabbleDabble changed the title Fix js error 'The parameter is incorrect' for upload [windows] Fix js error 'The parameter is incorrect' for upload Mar 7, 2019
@jcesarmobile
Copy link
Member

Thanks for the PR, but windows platform is deprecated and it’s code has been removed from the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants