Resolve issue with pbxFile extension #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where pbxFile extension was being set to 'undefined' and add new test case to verify the bug fix NOTE: These changes were originally part of apache#12 (cordova-node-xcode PR apache#12), extracted here by @brodybits (Christopher J. Brody). Co-authored-by: Kyle Spearrin <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
for the sake of consistency with the other test cases
|
All changes except for the quick test fix by @brodybits were already reviewed in PR #12. Merging now to help unblock the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where
pbxFileextension was being set toundefinedand add new test case to verify the bug fix
NOTE: These changes were originally part of PR #12,
extracted here by @brodybits (Christopher J. Brody).
/cc @n1ru4l @kspearrin