Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add code scanning & fix dependabot failures #1505

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Nov 19, 2024

Platforms affected

all

Motivation and Context

Improve CI.

Description

  • Fix errors when dependabot PRs try to run tests in CI
  • Add JavaScript code scanning with CodeQL

CodeQL doesn't support Objective C, and I tried enabling the Swift scanning but it caused everything to run so slowly that all the tests timed out. But we don't actually have much Swift code, do I doubt that it worth trying to enable that right now.

Testing

  • Ran in CI, tests pass

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 8.0.0 milestone Nov 19, 2024
@dpogue dpogue requested a review from erisu November 19, 2024 06:05
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (fc0d1a2) to head (87c7757).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   80.97%   80.97%           
=======================================
  Files          16       16           
  Lines        1850     1850           
=======================================
  Hits         1498     1498           
  Misses        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dpogue dpogue merged commit 74bfae8 into apache:master Nov 19, 2024
11 checks passed
@dpogue dpogue deleted the dependabot-fix branch November 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants