fix(ios, android): store cordova version in Info.plist and CordovaWebView.java #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Would be nice for the Info.plist for CordovaLib to reflect the right version string (even if it's not displayed anywhere).
Description
When tagging a new iOS version, updates the version string in CordovaLib's Info.plist
Also moved the tagging of the Android WebView versions string because I couldn't figure out a scenario in which the previous code would run, due to not having a VERSION file in the cordova-android repo.
Testing
Ran this locally against my cordova-ios repo and confirmed that the Info.plist was updated as expected.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)