Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, android): store cordova version in Info.plist and CordovaWebView.java #324

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 27, 2023

Platforms affected

iOS

Motivation and Context

Would be nice for the Info.plist for CordovaLib to reflect the right version string (even if it's not displayed anywhere).

Description

When tagging a new iOS version, updates the version string in CordovaLib's Info.plist

Also moved the tagging of the Android WebView versions string because I couldn't figure out a scenario in which the previous code would run, due to not having a VERSION file in the cordova-android repo.

Testing

Ran this locally against my cordova-ios repo and confirmed that the Info.plist was updated as expected.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #324 (b72986a) into master (c52b561) will increase coverage by 0.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   58.85%   59.80%   +0.94%     
==========================================
  Files           8        8              
  Lines         491      500       +9     
==========================================
+ Hits          289      299      +10     
+ Misses        202      201       -1     
Files Coverage Δ
src/repoutil.js 68.91% <ø> (ø)
src/versionutil.js 61.72% <100.00%> (+6.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu changed the title [iOS] Update CordovaLib's Info.plist version string when tagging fix(ios, android): store cordova version in Info.plist and CordovaWebView.java Oct 28, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue
Copy link
Member Author

dpogue commented Mar 27, 2024

So the problem here is that tests run against a version of cordova-ios that's set in package.json, and the changes in this PR are expecting to run against the master branch of cordova-ios because we moved some files around. I'm not sure how we want to deal with that case... but I guess at the very least I can check that the file exists at the path before trying to edit it.

@dpogue
Copy link
Member Author

dpogue commented Mar 27, 2024

Should hopefully be good to go now

@erisu erisu merged commit 873f6d6 into apache:master Mar 29, 2024
9 checks passed
@dpogue dpogue deleted the ios-infoplist branch October 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants