Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CB-3576] Privately signed https links don't work in InAppBrowser #63

Closed
wants to merge 1 commit into from

Conversation

montylee
Copy link

Privately signed https links don't work in InAppBrowser and are blocked by default on the InAppBrowser. A new option 'validatessl' has been added that can be specified while
launching the InAppBrowser:

window.open(url, '_blank', 'location=yes,validatessl=no');

Default value of 'validatessl' is 'yes'. This will allow users to ignore SSL certificate errors caused while opening self-signed https URLs

A new option 'validatessl' has  been added that can be specified while
launching the InAppBrowser:
window.open(url, '_blank', 'location=yes,validatessl=no');

Default value of 'validatessl' is 'yes'. This will allow users to ignore
SSL certificate errors caused while opening self-signed https URLs
@infil00p
Copy link
Member

When you say "privately signed", do you mean self-signed? I don't think we want to allow self-signed certificates to be viewed.

@montylee montylee closed this Jun 15, 2013
@montylee montylee reopened this Jun 15, 2013
@montylee
Copy link
Author

Yes I mean self signed certificate based URLs can't be opened in InAppBrowser. In the main PhoneGap web view you can open such URLs by simply overriding onReceivedSSLError() public method but the same can't be done for InAppBrowser. In all browsers on desktop and mobiles, you get an option of either blocking or proceeding with opening such URLs so basically you have a way of accessing self signed URLs.

Enterprise applications which rely on local web servers really need this functionality. And it's not that we are hard-coding inside the code to always allow self signed URLs. I have added an option so it's upto the user to decide what he wants on each invocation of InAppBrowser.

Right now, there is no way of opening self signed URLs inside InAppBrowser, so I wanted to add this functionality.

@montylee
Copy link
Author

iOS pull request link: apache/cordova-ios#59

@montylee
Copy link
Author

Any update on this pull request?

@chrispadfield
Copy link

Any update? This affects us as well; on enterprise intranets largely.

@agrieve
Copy link
Contributor

agrieve commented Oct 24, 2013

Relevant bug: https://issues.apache.org/jira/browse/CB-3576
The resolution is that we should add an interstitial to the IAB, but I think it's a low priority currently and none of the core team is working on it.

@montylee
Copy link
Author

closing this as this needs to be fixed by the Cordova team (including user confirmation dialog)

@montylee montylee closed this Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants