[tests] correct high/low naming of UTF-16 surrogate character test fixture constants #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…surrogate character test fixture constants; compose supplementary characters of declared surrogates where applicable (cf. 1f06eb4)
|
Hello @IBue Good catch! TY. The issue with this PR IMO is that it does more than addressing the name issue. Changing the tests makes reviewing and checking if something went wrong harder. For example, it's unclear if you are also fixing something in the test. If you update your git master branch, you'll see I took a simpler approach and only changed the 2 constant names and updated the Javadoc. You are credited in |
|
Thank you for your quick review and taking this into account. closing in favour of f0c370e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of the UTF-16 surrogate character test fixtures is semantically interchanged regarding "high" and "low".
This pull request corrects and clarifies the naming and also composes the supplementary character fixtures of the surrogate character test fixture constants where applicable.