Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mockito version from commons-parent #519

Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 19, 2025

replaces #514

this seems small enough not to need an entry in changes.xml, right?

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

replaces apache#514

this seems small enough not to need an entry in `changes.xml`,
right?
@garydgregory
Copy link
Member

@raboof
I agree! Merged.

@garydgregory garydgregory merged commit 8bf4049 into apache:master Jan 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants