Add optional FHCRC to GZIP header #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Dec 21, 2024
There was a problem hiding this comment.
Hello @ddeschenes-1
- Thank you for the PR.
- Rebase on git master to pick up the updated checkstyle configuration which will now notify you of missing
finalkeywords and@Override - Git master now also adds all missing
@Overrideannotations (a small conflict with this PR) - Please update the PR with my scattered comments.
TY!
src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
Show resolved
Hide resolved
src/main/java/org/apache/commons/compress/compressors/gzip/GzipParameters.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/compress/compressors/gzip/GzipCompressorOutputStreamTest.java
Outdated
Show resolved
Hide resolved
garydgregory
changed the title
garydgregory
changed the title
garydgregory
changed the title
garydgregory
changed the title
garydgregory
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the boolean to generate the header CRC in the gzip parameters, the GzipCompressorOutputStream will
compute and add the CRC16 (actually low 16 bits of the CRC32) of the headers, as per the RFC.
The GzipCompressorInputStream is still handling the presence of HCRC but still not computing nor checking it,
because this would be too much a risk of regression. It will however raise the HCRC boolean in the loaded gzip parameters
to signal it was seen.