Add API command remove management server

[nicoschmdt]

Description

This PR adds a command to mark a Management Server as removed on the database only if its status is marked as Down. To execute the command, it is obligatory to inform the id of the targeted MS.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

In a local lab, I added an MS through the database.

• With State="Down" I executed through CMK remove managementserver id=<uuid> and verified that the MS wasn't being listed on the UI and was marked as Removed on the database.
• With State="Up" I executed the same command and verified an error was returned informing it wasn't possible to remove an MS which state was marked as "Up".
• With State="Down" I executed through a URL http://<IP>:8080/client/api?command=removeManagementServer&response=json&id=<UUID> and verified the MS was marked as removed and wasn't being listed on the UI.
• With State="Up" I executed the same URL and received an error informing it wasn't possible to remove an MS which state was marked as "Up".
• Trying to execute the command with a non-existent id returns an error warning the request format may be invalid, the entity may not exist, or the parameter annotation may be wrong.
• Trying to execute the command without an id, both in CMK and with a URL, returns an error informing the id parameter is obligatory and it is missing.

[bernardodemarco]

@nicoschmdt, apparently the ManagementServerImpl.java file has conflicts. Could you resolve them, please?

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[bernardodemarco]

@blueorangutan package

[blueorangutan]

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12343

[codecov]

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 16.08%. Comparing base (a7beaaf) to head (84fe078).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
...nd/admin/management/RemoveManagementServerCmd.java	0.00%	18 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	11 Missing ⚠️
...com/cloud/api/query/vo/ManagementServerJoinVO.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10325      +/-   ##
============================================
- Coverage     16.08%   16.08%   -0.01%     
- Complexity    13176    13177       +1     
============================================
  Files          5659     5660       +1     
  Lines        496856   496889      +33     
  Branches      60168    60171       +3     
============================================
+ Hits          79933    79934       +1     
- Misses       407978   408010      +32     
  Partials       8945     8945              

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.93% <3.03%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[bernardodemarco]

clgtm