-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long running repairs autofail prematurely #3883
base: cassandra-4.0
Are you sure you want to change the base?
Conversation
@@ -1021,6 +1021,7 @@ public void handleStatusResponse(InetAddressAndPort from, StatusResponse respons | |||
} | |||
else | |||
{ | |||
session.setLastUpdate(); | |||
logger.debug("Received StatusResponse for repair session {} with state {}, which is not actionable. Doing nothing.", sessionID, response.state); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are technically not Doing nothing
anymore right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think icwym. You're probably referring to the junit being named 'noop'? It depends a lot on how you parse that in your brain imo. I read it as it's noop in terms of the status of the repair, which doesn't change. You probably read it as a pure 100% noop whereas now we're updating a timestamp? Some other people read junits as a pseudo-doc of the expected behavior of what a noop status operation should do 🤷 I think we're good and we avoid adding an extra almost identical test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (nb)
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira