Cxf-soap: tests are not working in FIPS environment #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure of CI (MongoDB Grouped and Debezium) is not caused by this change |
zhfeng
approved these changes
Apr 8, 2024
|
@JiriOndrusek I assume this PR is still needed? If so, please rebase. |
JiriOndrusek
force-pushed
the
fips-cxf-grouped
branch
from
9db5d6c to
3ce89eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5979
@ppalaga I thought, that the regenaration of keystores + some additional logic handling FIPS in tests would be needed (similar to quarkiverse/quarkus-cxf#1297 and quarkiverse/quarkus-cxf#1174). With the current simple fix the test suite works in FIPS environment.
WDYT?
a. Should we keep the fix this small? (I think so)
b. Should we consider making the tests more covering (to use keystores properly)? (I'm not sure of it)