Fix the usage of karavan.git.branch on git clone (Closes issue #1347) #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when something is wrong with initial git clone
thgruiz
changed the title
davsclaus
approved these changes
Sep 3, 2024
|
Wonderful, thank you @thgruiz ! I hope this gets approved soon and the next ghcr-image contains the fix. Can't wait to test. |
|
Thanks everyone, now it works and we can proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small changes on this PR:
change 1) Adds more details on log message on git init
When something went wrong on the git clone process, I was getting those logs entries:
And was not able to know what was going on (had to debug to check)
So just added the exception to the log message to get a clearer picture:
(note: this change would have helped the guy from #1347 to know the variable name was wrong, I think...)
change 2) Adds the configured branch name to git clone command, to prevent errors like these:
In the above case, my git repo had a different default branch from what was configured on the env var KARAVAN_GIT_BRANCH.
this, I presume, will close issue the #1347