Add e2e traits test for cron #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Apr 24, 2024
There was a problem hiding this comment.
I think the cron trait scenarios are implicitly tested in https://github.com/apache/camel-k/blob/main/e2e/common/misc/cron_test.go so this would be a duplicate - you can see cron has the auto setting as default, which mean, it scans the source to discover if any cron trait configuration can be inferred by the source.
|
BTW, as mentioned already in the past, please, avoid referencing any downstream reference such as specific company Jira issues or the like. Thanks. |
tdiesler
force-pushed
the
CMLK-1387-cron
branch
from
90ea32c to
25b138e
Compare
tdiesler
changed the title
|
The test verifies that |
squakez
approved these changes
Apr 24, 2024
tdiesler
force-pushed
the
CMLK-1387-cron
branch
from
25b138e to
650a8a6
Compare
gansheer
approved these changes
Apr 24, 2024
|
Ready to merge |
|
Please, backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.