Add support for kubernetes helm #830
Conversation
|
retest this please |
|
@andreaturli Might be completely off-base here but wouldn't it make more sense for this to be in the clocker project |
|
good question @tbouron -- I think Helm is a package manager for Kubernets and helps you deploy application to kubernetes. Seemed to me the |
There was a problem hiding this comment.
Fair enough @andreaturli. LGTM from a code POV. Is there any way I can test this myself?
locations/container/pom.xml
Outdated
| <!--<exclusion>--> | ||
| <!--<groupId>io.grpc</groupId>--> | ||
| <!--<artifactId>grpc-netty</artifactId>--> | ||
| <!--</exclusion>--> |
There was a problem hiding this comment.
thanks @tbouron
also now there is an official release http://search.maven.org/#search%7Cga%7C1%7Ca%3Amicrobean-helm which may be better and needs testing
There was a problem hiding this comment.
Ah ok, I'll let you decide which one is best then ;)
locations/container/pom.xml
Outdated
| <!--<exclusion>--> | ||
| <!--<groupId>com.google.instrumentation</groupId>--> | ||
| <!--<artifactId>instrumentation-api</artifactId>--> | ||
| <!--</exclusion>--> |
| @@ -347,8 +386,8 @@ public Boolean call() { | |||
| if (result.isEmpty()) { | |||
| return false; | |||
| } | |||
| List<HasMetadata> check = client.resource(result.get(0)).inNamespace(result.get(0).getMetadata().getNamespace()).get(); | |||
| if (result.size() > 1 || check.size() != 1 || check.get(0).getMetadata() == null) { | |||
| HasMetadata check = client.resource(result.get(0)).inNamespace(result.get(0).getMetadata().getNamespace()).get(); | |||
There was a problem hiding this comment.
Is that normal the signature changed from List<HasMetadata> to HasMetadata ?
There was a problem hiding this comment.
think so, but need to double-check as I don't recall the details
|
@tbouron I remember I used minikube to test it. Any k8s cluster should work though |
|
would be great to have this merged! nearly there IMO. re clocker, deploy to i think of as Brooklyn, and this is squarely in that camp ... deploy of {k8s,docker,etc} is more clocker. would be nice to have a yaml example -- ideally a docs addition that references an example tested here (is there a brooklyn-docs PR ?). also nice to have another pair of eyes on this but given the time and value, and i've looked at the code and am happy with it, i'm happy for this to be merged. |
andreaturli
force-pushed
the
feature/container-k8s-helm
branch
from
209be64 to
42ea31c
Compare
andreaturli
force-pushed
the
feature/container-k8s-helm
branch
2 times, most recently
from
0a78073 to
96015e6
Compare
- bump microbean-helm version - support default stable ChartRepository - use auto-generated release name
andreaturli
force-pushed
the
feature/container-k8s-helm
branch
from
96015e6 to
6ddc595
Compare
|
retest this please |
|
@tbouron as per our review, I've add the creation of some it basically mimics the same approach taken by the |
|
Just tested, works like a charm, thanks @andreaturli ! Just need to make Jenkins happy again and I'll merge it 👍 |
|
retest this please |
Revert "Revert "This closes apache#830"" This reverts commit 4236ff2.
Revert "Revert "This closes apache#830"" This reverts commit 4236ff2.
Revert "Revert "This closes apache#830"" This reverts commit 4236ff2.
No description provided.