Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] remove PortableTemplateBuilder #807

Closed
wants to merge 1 commit into from

Conversation

andreaturli
Copy link
Contributor

  • adjust MachinePoolPredicates to use Template from jclouds

- adjust MachinePoolPredicates to use Template from jclouds
@m4rkmckenna
Copy link
Member

m4rkmckenna commented Aug 30, 2017

@andreaturli Test failures look related

org.apache.brooklyn.location.jclouds.JcloudsLocationExtensionStubbedTest.testHasExtension
org.apache.brooklyn.location.jclouds.JcloudsRebindStubUnitTest.testRebind
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationAddressOverwriteTest.testSetPrivateIpToPublicIp
org.apache.brooklyn.location.jclouds.JcloudsTemplateOptionsStubbedTest.testTemplateOption
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testMachineUsesFirstPublicAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testMachineUsesReachablePrivateAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testMachineUsesReachablePublicAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testMachineUsesVanillaPrivateAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testMachineUsesVanillaPublicAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testNoPollForFirstReachable
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testNoWaitForSshable
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testPublicPrivatePreference
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testPublicPrivatePreference
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testPublicPrivatePreference
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testPublicPrivatePreference
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testPublicPrivatePreference
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testReachabilityChecksWithPortForwarding
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testWindowsMachineUsesVanillaPublicAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsReachableAddressStubbedTest.testWindowsReachabilityChecksWithPortForwarding
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testNodeObtainErrorCustomizer
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testNodeObtainErrorCustomizerNoDestroy
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testNodeSetupCustomizer
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testSshConfigPassedToMachine
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testWinrmConfigPassedToMachine
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testWithNoPrivateAddress
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocationStubbedTest.testWithPrivateAddress
org.apache.brooklyn.location.jclouds.networking.JcloudsPortForwardingStubbedTest.testDeregistersWithPortForwardManagerOnRelease
org.apache.brooklyn.location.jclouds.networking.JcloudsPortForwardingStubbedTest.testPortForwardingCallsForwarder
org.apache.brooklyn.location.jclouds.networking.JcloudsPortForwardingStubbedTest.testReleaseVmDoesNotImpactOtherVms

@andreaturli
Copy link
Contributor Author

@m4rkmckenna they are! sorry about that, closing the PR now while fixing those tests

@m4rkmckenna
Copy link
Member

@andreaturli You can leave open ... just stick a WIP in the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants