-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency stats for entry location index lookup so that possible RocksDB bottleneck can be detected #3444
Add latency stats for entry location index lookup so that possible RocksDB bottleneck can be detected #3444
Conversation
- this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed
8383e47
to
f315686
Compare
...keeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java
Outdated
Show resolved
Hide resolved
...keeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have the index lookup stats read-locations-index-time
, does it has any case this metric can't cover?
Line 48 in de5d45f
private static final String READ_ENTRY_LOCATIONS_INDEX_TIME = "read-locations-index-time"; |
thanks for pointing that out @hangc0276 . The problem with the Lines 344 to 348 in 4ee8c04
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…cksDB bottleneck can be detected (#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7) (cherry picked from commit d2d8194)
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name
Motivation
and RocksDB tuning is needed
Changes
Add new operation latency metrics
lookup-entry-location
which will be provided at the same level of metrics as the existingentries-count
metric.