Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: utilize cmp package for comparison in Go test files #33922

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Feb 8, 2025

Description

In this PR, we mainly replace reflect.DeepEqual with the cmp package for comparisons in Go test files (*_test.go). The cmp package provides a more powerful and safer alternative for value equality checks.

Closes #20154.

Motivation and Context

As stated in the upstream issue and the cmp documentation:

Package cmp determines equality of values.
This package is intended to be a more powerful and safer alternative to reflect.DeepEqual for comparing whether two values are semantically equal.

The upsteram issue specifically mentioned fullvalue_test.go. However, I think this improvement can be extended to other test files as well.

To facilitate review, this PR includes two commits:

  1. The first commit updates fullvalue_test.go.
  2. The second commit updates the remaining test files.

This separation allows for easier discussion and review of changes in case we decide to extend it to other test files.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cmp in fullvalue_test.go
1 participant