-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlloyDB vector writer. #33841
base: master
Are you sure you want to change the base?
Add AlloyDB vector writer. #33841
Conversation
2990de5
to
a6311f5
Compare
a6311f5
to
aa53511
Compare
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
||
Attributes: | ||
name: The column name in the database table. | ||
python_type: Python type for the column value (used in NamedTuple field) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a set of supported types here? Is it basically anything that Alloy supports/is there a doc we could link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the supported types are anything that RowCoder can handle, I added this to the docstring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33841 +/- ##
============================================
- Coverage 59.48% 59.48% -0.01%
Complexity 4683 4683
============================================
Files 1348 1349 +1
Lines 184681 184902 +221
Branches 4455 4455
============================================
+ Hits 109852 109981 +129
- Misses 71088 71180 +92
Partials 3741 3741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Disabled test while I figure out how to configure the database arguments to run in dataflow and github action runners.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.