Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlloyDB vector writer. #33841

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

claudevdm
Copy link
Contributor

@claudevdm claudevdm commented Feb 3, 2025

Disabled test while I figure out how to configure the database arguments to run in dataflow and github action runners.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Contributor Author

R: @damccorm

@claudevdm claudevdm marked this pull request as ready for review February 3, 2025 20:29
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

sdks/python/apache_beam/ml/rag/ingestion/alloydb.py Outdated Show resolved Hide resolved

Attributes:
name: The column name in the database table.
python_type: Python type for the column value (used in NamedTuple field)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a set of supported types here? Is it basically anything that Alloy supports/is there a doc we could link to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the supported types are anything that RowCoder can handle, I added this to the docstring.

sdks/python/apache_beam/ml/rag/ingestion/alloydb.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 51.06383% with 69 lines in your changes missing coverage. Please review.

Project coverage is 59.48%. Comparing base (949b988) to head (040dc47).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...dks/python/apache_beam/ml/rag/ingestion/alloydb.py 51.06% 69 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33841      +/-   ##
============================================
- Coverage     59.48%   59.48%   -0.01%     
  Complexity     4683     4683              
============================================
  Files          1348     1349       +1     
  Lines        184681   184902     +221     
  Branches       4455     4455              
============================================
+ Hits         109852   109981     +129     
- Misses        71088    71180      +92     
  Partials       3741     3741              
Flag Coverage Δ
python 81.17% <51.06%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants