Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Revert LargeCommitTest #33745

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Revert Revert LargeCommitTest #33745

merged 2 commits into from
Jan 23, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 23, 2025

Reverts #33597

The added test is permared

@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2025

R: @Amar3tto @arunpandianp

cc: @scwhittle

@arunpandianp
Copy link
Contributor

Sorry for the trouble. The test is running into user worker memory limits. We can revert the test, but not the fix.

@github-actions GitHub Actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2025

@arunpandianp thanks for prompt reply, done

@arunpandianp
Copy link
Contributor

Thanks, LGTM

@arunpandianp arunpandianp mentioned this pull request Jan 23, 2025
Closed
@arunpandianp
Copy link
Contributor

Can we update the PR title to something like "Revert LargeCommitTest"?

@ahmedabu98
Copy link
Contributor

Fixes #33746

@Abacn Abacn changed the title Revert "[Dataflow Streaming Appliance] Fix per key commit size validation" Revert Revert LargeCommitTest Jan 23, 2025
@Abacn Abacn mentioned this pull request Jan 23, 2025
Closed
3 tasks
@Abacn
Copy link
Contributor Author

Abacn commented Jan 23, 2025 •
edited
Loading

testConsumedWorkItems_itemsSplitAcrossResponses (org.apache.beam.runners.dataflow.worker.windmill.client.grpc.GrpcDirectGetWorkStreamTest) failed, known issue #28957

not related to this change

@Abacn Abacn merged commit c0e1ec0 into master Jan 23, 2025
13 of 15 checks passed
@Abacn Abacn deleted the revert-33597-fixCommitLarge branch January 23, 2025 21:32
This was referenced Jan 24, 2025
Closed
Closed
Closed
Closed
Closed
@ahmedabu98 ahmedabu98 mentioned this pull request Jan 24, 2025
Closed
17 tasks
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
@Abacn @VardhanThigle
Revert Revert LargeCommitTest (apache#33745)
8aeb9dc 
* Revert "[Dataflow Streaming Appliance] Fix per key commit size validation (apache#3…"

This reverts commit edc4766.

* keep main src change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dataflow runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abacn @arunpandianp @ahmedabu98