Allow annotations to be attached to transforms via a context. #33319
Conversation
robertwb
force-pushed
the
context-attributes
branch
from
993b030 to
fbcf2e0
Compare
robertwb
force-pushed
the
context-attributes
branch
from
fbcf2e0 to
ac7ae9f
Compare
This API is offered both on the pipeline object itself, and also as a (thread-local) top-level function as one many not always have an easy reference to the pipeline.
robertwb
force-pushed
the
context-attributes
branch
from
ac7ae9f to
d491769
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @shunping |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
|
…#33319) This API is offered both on the pipeline object itself, and also as a (thread-local) top-level function as one many not always have an easy reference to the pipeline.
| @@ -1124,8 +1153,8 @@ def __init__( | |||
| transform, # type: Optional[ptransform.PTransform] | |||
| full_label, # type: str | |||
| main_inputs, # type: Optional[Mapping[str, Union[pvalue.PBegin, pvalue.PCollection]]] | |||
| environment_id=None, # type: Optional[str] | |||
| annotations=None, # type: Optional[Dict[str, bytes]] | |||
| environment_id, # type: Optional[str] | |||
There was a problem hiding this comment.
It seems that removing the default value for these two arguments causes some internal test to fail (internal bug id: 394194442). Fortunately, it is trivial to fix such tests.
There was a problem hiding this comment.
It's incorrect to leave these two out (and setting environment_id to None could have caused issues in some cases as well). Looking at an internal fix.
This API is offered both on the pipeline object itself, and also as a (thread-local) top-level function as one many not always have an easy reference to the pipeline.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.