Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreCommit_Portable_Python fix: use double quotes when using embedded values #26151

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

ahmedabu98
Copy link
Contributor

No description provided.

@ahmedabu98
Copy link
Contributor Author

Run Portable_Python PreCommit

@ahmedabu98
Copy link
Contributor Author

R: @AnandInguva

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@ahmedabu98
Copy link
Contributor Author

R: @tvalentyn

@ahmedabu98
Copy link
Contributor Author

@Abacn

@Abacn
Copy link
Contributor

Abacn commented Apr 6, 2023

run seed job

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger not working. Nevertheless this fix is so obvious let me get it in to get precommit back green

@Abacn Abacn merged commit d4731aa into apache:master Apr 6, 2023
Abacn pushed a commit to Abacn/beam that referenced this pull request Apr 7, 2023
jrmccluskey pushed a commit that referenced this pull request Apr 10, 2023
…26184)

* use double quotes when using embedded values (#26151)

* Fix a couple of Python3.11 support followup (#26174)

* Fix a couple of Python3.11 support followup

* Bump tenacity version for pull_license script support Py3.11

* Fix Sickbay test no task defined

* Still Run ALL_SUPPORTED_VERSIONS For Python Sickbay

---------

Co-authored-by: Ahmed Abualsaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants