Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorFlow object detection example #23754

Closed
wants to merge 3 commits into from

Conversation

yeandy
Copy link
Contributor

@yeandy yeandy commented Oct 20, 2022

This PR adds a TensorFlow object detection example using the MobileNet v2 320x320 model and the TensorFlow RunInference API. This is the same model that is used in the TensorRT object detection example using TensorRTRunInference API.

The goal is to be able to benchmark both implementations on DataFlow. I've added a larger dataset gs://apache-beam-ml/testing/inputs/coco_train_inputs.txt that contains 118287 examples.

Current status: I am running into an issue with signature dtypes. See #23756


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #23754 (158eda6) into master (3dd2072) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head 158eda6 differs from pull request most recent head dbdfd2a. Consider uploading reports for the commit dbdfd2a to get more accurate results

@@            Coverage Diff             @@
##           master   #23754      +/-   ##
==========================================
- Coverage   73.23%   73.12%   -0.11%     
==========================================
  Files         719      721       +2     
  Lines       95962    96143     +181     
==========================================
+ Hits        70277    70305      +28     
- Misses      24373    24526     +153     
  Partials     1312     1312              
Flag Coverage Δ
python 82.86% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../examples/inference/tensorflow_object_detection.py 0.00% <0.00%> (ø)
...python/apache_beam/io/gcp/bigquery_schema_tools.py 79.24% <0.00%> (-4.85%) ⬇️
sdks/python/apache_beam/internal/gcp/auth.py 79.16% <0.00%> (-3.70%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.08% <0.00%> (-0.17%) ⬇️
sdks/python/apache_beam/io/gcp/gcsio.py 92.12% <0.00%> (-0.14%) ⬇️
sdks/python/apache_beam/ml/gcp/visionml.py 92.59% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant