Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4113: [c++] Don't generate tests files if test are not requested #3298

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

pkubanek
Copy link
Contributor

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Jan 22, 2025
@pkubanek pkubanek changed the title Don't generate tests files if test are not requested AVRO-4113: [c++] Don't generate tests files if test are not requested Jan 22, 2025
@martin-g
Copy link
Member

For some reason the CI checks didn't run.
I'll close/reopen.

@martin-g martin-g closed this Jan 22, 2025
@martin-g martin-g reopened this Jan 22, 2025
@thiru-mg thiru-mg merged commit db738a7 into apache:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants