AVRO-2108: [Java] DoubleArray converts double to float on array add #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Jan 10, 2025
lang/java/avro/src/test/java/org/apache/avro/generic/PrimitivesArraysTest.java
Show resolved
Hide resolved
martin-g
approved these changes
Jan 10, 2025
sarthaksin1857
changed the title
sarthaksin1857
changed the title
|
@martin-g The PR didn't get merged as I accidentally set it as a draft PR. Would you mind merging it when you get the chance? |
|
Hello, is this still being worked on? |
There's a similar PR that I submitted that covers some additional uses cases: |
|
@davidschmitz-surescripts this PR is done, waiting for it to be merged. Did I need to submit anything else? |
rdifrango
reviewed
Jan 21, 2025
lang/java/avro/src/main/java/org/apache/avro/generic/PrimitivesArrays.java
Outdated
Show resolved
Hide resolved
Fokko
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixing AVRO-4108
Verifying this change
This change added a single test which simulates the issue
testDoubleArrayPreservesPrecisionForNonFloatRepresentableValueswhich creates a double value that cannot be represented by float. It adds it to the array and then verifies that it still contains the double value.Documentation
This is a bug fix so no documentation needed. I added comments in the test to explain the issue.