Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUnit3TestAdapter NuGet packages. The latter
allows developers to run unit tests in Visual Studio's Test Explorer. Adding a reference to the
test adapter from the test library is standard operating procedure
(see here). Now that we are using NuGet
packages, developers must execute a NuGet restore before building. This happens automatically when
using Visual Studio. On Linux this is done with
mono nuget.exe restore
. I updated the README to reflectthese changes.
are documented in the NUnit Breaking Changes for
the v3 release. Below are the specific changes that applied to the Avro unit test code base:
ExpectedExceptionAttribute
: No longer supported. UseAssert.Throws
orAssert.That
.TestFixtureSetUpAttribute
: Deprecated. UseOneTimeSetUpAttribute
.TestFixtureTearDownAttribute
: Deprecated. UseOneTimeTearDownAttribute
.TestContext.CurrentContext.TestDirectory
to locate that directory.TestCaseAttribute
: Named parameterResult=
is no longer supported. UseExpectedResult=
.Named parameter
Ignore=
now takes a string, giving the reason for ignoring the test.TestCaseSourceAttribute
: The attribute forms using a string argument to refer to the data sourcemust now use only static fields, properties or methods.
TestCase
attribute contents were too long,resulting in errors loading the tests. For these, I added a
TestName
parameter to provide a short, human readablename for the test.
TestCase
s (NUnit identified these with warnings while loading tests)PackageReference
element in the*.csproj
files for describing NuGet package dependencies.I've tested these changes and confirmed 520 passing unit tests in the following environments: