ARROW-9910: [Rust][DataFusion] Fixed error in type coercion of Variadic. #8108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @alamb , @andygrove |
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
The background of this error is that we currently use `numerical_coercion(lhs, rhs)` function to check if a coercion rule applies, but that function tries to come up with a common type between lhs and rhs. We should be using the function `can_coerce_from` to check if a cast can be performed. This commit fixes this. Closes apache#8108 from jorgecarleitao/type_fix Authored-by: Jorge C. Leitao <[email protected]> Signed-off-by: Paddy Horan <[email protected]>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
The background of this error is that we currently use `numerical_coercion(lhs, rhs)` function to check if a coercion rule applies, but that function tries to come up with a common type between lhs and rhs. We should be using the function `can_coerce_from` to check if a cast can be performed. This commit fixes this. Closes apache#8108 from jorgecarleitao/type_fix Authored-by: Jorge C. Leitao <[email protected]> Signed-off-by: Paddy Horan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background of this error is that we currently use
numerical_coercion(lhs, rhs)function to check if a coercion rule applies, but that function tries to come up with a common type between lhs and rhs. We should be using the functioncan_coerce_fromto check if a cast can be performed.This commit fixes this.