Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45380: [Python] Expose RankQuantileOptions to Python #45392

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 30, 2025

Rationale for this change

RankQuantileOptions are currently not exposed on Pyarrow and CI job breaks when -W error is used.

What changes are included in this PR?

Expose RankQuantileOptions and test options and kernel from pyarrow.

It also includes some minor refactor for the unwrap sort keys logic to move it into a common function.

Are these changes tested?

Yes

Are there any user-facing changes?

The options for the new kernel are exposed on pyarrow.

@raulcd
Copy link
Member Author

raulcd commented Jan 30, 2025

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 30, 2025
Copy link

Revision: ff3a84d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c71ec9f5c5

Task Status
test-conda-python-3.11-hypothesis GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jan 30, 2025

The sporadic failure on test-conda-python-3.11-hypothesis is a different issue tracked here:

The RankQuantileOptions warning for it not being exposed has been solved.

edit: the job was successful on retry

@raulcd raulcd requested a review from pitrou January 30, 2025 11:16
python/pyarrow/_compute.pyx Outdated Show resolved Hide resolved
@@ -65,6 +65,8 @@ cdef CExpression _true

cdef CFieldRef _ensure_field_ref(value) except *

cdef vector[CSortKey] unwrap_sort_keys(sort_keys, allow_str=*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be except * since it calls _ensure_field_ref which can raise an exception.

@pitrou
Copy link
Member

pitrou commented Feb 5, 2025

@github-actions crossbow submit -g python

Copy link

github-actions bot commented Feb 5, 2025

Revision: 86d7827

Submitted crossbow builds: ursacomputing/crossbow @ actions-c2a80e324c

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@pitrou
Copy link
Member

pitrou commented Feb 5, 2025

CI failures look unrelated.

@pitrou pitrou merged commit 0556905 into apache:main Feb 5, 2025
36 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Feb 5, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0556905.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants