-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45380: [Python] Expose RankQuantileOptions to Python #45392
Conversation
@github-actions crossbow submit test-conda-python-3.11-hypothesis |
Revision: ff3a84d Submitted crossbow builds: ursacomputing/crossbow @ actions-c71ec9f5c5
|
The sporadic failure on The edit: the job was successful on retry |
python/pyarrow/_compute.pxd
Outdated
@@ -65,6 +65,8 @@ cdef CExpression _true | |||
|
|||
cdef CFieldRef _ensure_field_ref(value) except * | |||
|
|||
cdef vector[CSortKey] unwrap_sort_keys(sort_keys, allow_str=*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be except *
since it calls _ensure_field_ref
which can raise an exception.
@github-actions crossbow submit -g python |
Revision: 86d7827 Submitted crossbow builds: ursacomputing/crossbow @ actions-c2a80e324c |
CI failures look unrelated. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0556905. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
RankQuantileOptions
are currently not exposed on Pyarrow and CI job breaks when-W error
is used.What changes are included in this PR?
Expose
RankQuantileOptions
and test options and kernel from pyarrow.It also includes some minor refactor for the unwrap sort keys logic to move it into a common function.
Are these changes tested?
Yes
Are there any user-facing changes?
The options for the new kernel are exposed on pyarrow.