GH-44760: [GLib] Add garrow_record_batch_validate_full() #45386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hiroyuki-sato
force-pushed
the
topic/record-batch-validate-full
branch
from
f987e36 to
d40dc1d
Compare
hiroyuki-sato
force-pushed
the
topic/record-batch-validate-full
branch
from
d40dc1d to
26eecda
Compare
kou
reviewed
Jan 30, 2025
github-actions
bot
added
awaiting changes
kou
reviewed
Jan 30, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
github-actions
bot
added
awaiting change review
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
…e#45386) ### Rationale for this change [RecordBatch::ValidateFull](https://arrow.apache.org/docs/cpp/api/table.html#_CPPv4NK5arrow11RecordBatch12ValidateFullEv) available in the C++ API. But, GLib doesn't support that method yet. ### What changes are included in this PR? This PR adds a validation method in the record-batch class. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#44760 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 99dd237. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
RecordBatch::ValidateFull available in the C++ API.
But, GLib doesn't support that method yet.
What changes are included in this PR?
This PR adds a validation method in the record-batch class.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
garrow_record_batch_validate_full()#44760