-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44614: [Python][C++] Add version suffix to libarrow_python* libraries #44702
Conversation
@github-actions crossbow submit -g python |
|
@github-actions crossbow submit -g wheel |
Revision: 07b1f4e Submitted crossbow builds: ursacomputing/crossbow @ actions-a85f386da9 |
Revision: 07b1f4e Submitted crossbow builds: ursacomputing/crossbow @ actions-c44ab3558a |
CI failures are currently occurring at nightly jobs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@raulcd thank you! |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d7641dc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We are currently not setting library version suffixes for arrow python C++ libraries but we do so for libarrow C++.
What changes are included in this PR?
Add the same logic that we use for libarrow.
Are these changes tested?
I've validated manually that the suffixes are generated.
Are there any user-facing changes?
We will generate so libraries with version suffixes.