-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache #44644
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5a6a3b9
GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache
kou 44ab063
Install NuGet
kou 4fd9bb3
Copy
kou 245a860
Use nuget.config
kou dbae9ac
Install Mono
kou 96a0de0
Use actions/cache instead of NuGet
kou f3b63f7
Use file based cache too
kou 5167236
Use NuGet
kou f69667f
Add missing escape
kou b089958
Remove garbage
kou 4f45593
Debug
kou c58ebb6
Use GITHUB_REPOSITORY_OWNER
kou cec044e
Debug
kou b1d41ca
Debug
kou faf85b8
Set GITHUB_TOKEN
kou ec80743
Simplify
kou a4a24f1
Reuse cache setup
kou 5c46134
Reuse cache setup
kou 8fdf349
Try removing workaround
kou ba97e21
Try push
kou c9400dd
Revert --quiet
kou 02d98a9
Revert needless changes
kou ff6a193
java-jars
kou d7114e7
Use mono-core on CentOS 7
kou e0bb0be
Don't use NuGet cache in manylinux2014_aarch64
kou 66940c7
Enable VCPKG_BINARY_SOURCES explicitly
kou 141cc07
Fix
kou c239815
Fix arch
kou 6730902
Use secret mount
kou 5d00978
Style
kou 013c5bb
Remove java-jni
kou 52b6ee9
Fix syntax
kou b2238ef
Fix English
kou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in which case would
VCPKG_BINARY_SOURCES
be different toclear;nuget,GitHub,readwrite
? onmanylinux2014_aarch64
this wouldn't be present but not different, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
VCPKG_BINARY_SOURCES
is notclear;nuget,GitHub,readwrite
(including not present case onmanylinux2014_aarch64
), we don't configure NuGet automatically.Ignoring not
clear;nuget,GitHub,readwrite
VCPKG_BINARY_SOURCES
is for using other cache. For example, we may want to use local file cache for localarchery docker run
. But it's out-of-scope of this PR and it's not tested. If we need it, we can work on it as a separated task.