Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C#] Remove launchSettings.json #39382

Merged

Conversation

CurtHagenlocher
Copy link
Contributor

Rationale for this change

A previous commit accidentally included a version of launchSettings.json used for local debugging. This file is not helpful to anyone.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 27, 2023
@CurtHagenlocher CurtHagenlocher merged commit bcaeaa8 into apache:main Dec 27, 2023
9 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting merge Awaiting merge label Dec 27, 2023
@CurtHagenlocher CurtHagenlocher deleted the dev/curth/RemoveLaunchSettings branch December 27, 2023 19:33
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bcaeaa8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
### Rationale for this change

A previous commit accidentally included a version of launchSettings.json used for local debugging. This file is not helpful to anyone.

### Are these changes tested?

N/A

### Are there any user-facing changes?

No.

Authored-by: Curt Hagenlocher <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

A previous commit accidentally included a version of launchSettings.json used for local debugging. This file is not helpful to anyone.

### Are these changes tested?

N/A

### Are there any user-facing changes?

No.

Authored-by: Curt Hagenlocher <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants