Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38977: [C++] Fix spelling #38978

Merged
merged 31 commits into from
Dec 10, 2023
Merged

GH-38977: [C++] Fix spelling #38978

merged 31 commits into from
Dec 10, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 29, 2023 •
edited by github-actions bot
Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

jsoref added 30 commits November 29, 2023 00:28
@jsoref
reword: comments out of scope
d61a215 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: across
b32d89b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: add
10941ab 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: anymore
233fce3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: at least
f51e14d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: brotli
72d703b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: build
740da20 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cannot
617e155 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: case-insensitive
9c8462a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: case-sensitive
9a6ce88 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: command
c53e285 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: default
d0a375d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: execution
3180363 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: failures
f8d699c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: fatal
eb3141b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: it
58e0448 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: macos
cf6a854 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: messages
848016d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: metadata
8b6f65b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: misleading
b500b4b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: programmatically
4e9ec8a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: required
540cc4e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: sizeless
7797dba 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: subdirectories
dd5e0e6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: substitute
e833b9d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: suppress
1b7959d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: suppressions
0388a18 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unconditionally
7cd433f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: variable
92ffa31 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: werror
73294ba 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: with
87272e5 
Signed-off-by: Josh Soref <[email protected]>
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #38977 has been automatically assigned in GitHub to PR creator.

kou
kou approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 539f31c into apache:main Dec 10, 2023
@kou kou removed the awaiting review Awaiting review label Dec 10, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 10, 2023
@jsoref jsoref deleted the spelling-cpp-not-src branch December 10, 2023 12:58
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 539f31c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Dec 13, 2023
@jsoref @mapleFU
apacheGH-38977: [C++] Fix spelling (apache#38978)
586ce3a 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38977

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
@jsoref @clayburn
apacheGH-38977: [C++] Fix spelling (apache#38978)
0c1992f 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38977

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@jsoref @dgreiss
apacheGH-38977: [C++] Fix spelling (apache#38978)
3ec5fcc 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38977

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++ Component: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] Spelling errors identified by check-spelling
2 participants
@jsoref @kou