GH-38925: [CI] Fix spelling #38926
GH-38925: [CI] Fix spelling #38926
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
|
| @@ -328,7 +328,7 @@ def _with_boost(self, required=False): | |||
| return bool(self.options.with_boost) | |||
|
|
|||
| def _with_thrift(self, required=False): | |||
| # No self.options.with_thift exists | |||
| # No self.options.with_thrift exists | |||
There was a problem hiding this comment.
Could you report this to the upstream?
https://github.com/conan-io/conan-center-index/blob/master/recipes/arrow/all/conanfile.py
There was a problem hiding this comment.
I've added the repository to my to-do list, but I'm already a number of levels upstream. I can try to do it once I clear out the rest of these splits...
(I did Google FlatBuffers)
| @@ -78,7 +78,7 @@ arrow::Status VectorToColumnarTable(const std::vector<struct data_row>& rows, | |||
| // Indicate the start of a new list row. This will memorise the current | |||
| // offset in the values builder. | |||
| ARROW_RETURN_NOT_OK(components_builder.Append()); | |||
| // Store the actual values. The final nullptr argument tells the underyling | |||
| // Store the actual values. The final nullptr argument tells the underlying | |||
There was a problem hiding this comment.
Could you report this to the upstream?
https://github.com/conan-io/conan-center-index/blob/master/recipes/arrow/all/test_package/test_package.cpp
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e3c8187. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change ### What changes are included in this PR? Spelling fixes to ci/ ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38925 Authored-by: Josh Soref <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change ### What changes are included in this PR? Spelling fixes to ci/ ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38925 Authored-by: Josh Soref <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change ### What changes are included in this PR? Spelling fixes to ci/ ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#38925 Authored-by: Josh Soref <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
What changes are included in this PR?
Spelling fixes to ci/
Are these changes tested?
Are there any user-facing changes?