Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35528:[Java] Fix RangeEqualsVisitor comparing BitVector with different begin index #35525

Merged
merged 3 commits into from
May 12, 2023
Merged

GH-35528:[Java] Fix RangeEqualsVisitor comparing BitVector with different begin index #35525

merged 3 commits into from
May 12, 2023

Conversation

wenxlan
Copy link
Contributor

@wenxlan wenxlan commented May 10, 2023 •
edited by lidavidm
Loading

Rationale for this change

bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index.

In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it.

What changes are included in this PR?

only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test

Are these changes tested?

yes.

Are there any user-facing changes?

no.

@wenxlan wenxlan requested a review from lidavidm as a code owner May 10, 2023 10:43
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@wenxlan wenxlan changed the title bugfix: RangeEqualsVisitor compare BitVector have error GH-35528:[Java]bugfix: RangeEqualsVisitor compare BitVector have error May 10, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35528 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm changed the title GH-35528:[Java]bugfix: RangeEqualsVisitor compare BitVector have error GH-35528:[Java] Fix RangeEqualsVisitor comparing BitVector with different begin index May 10, 2023
lidavidm
lidavidm reviewed May 10, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks!

(Just one comment.)

java/vector/src/test/java/org/apache/arrow/vector/compare/TestRangeEqualsVisitor.java Outdated
import org.apache.arrow.vector.LargeVarCharVector;
import org.apache.arrow.vector.VarCharVector;
import org.apache.arrow.vector.ZeroVector;
import org.apache.arrow.vector.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I realize this was probably the IDE but can this be reverted? For review it's easier to list out imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is reverted now～

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels May 10, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 11, 2023
lidavidm
lidavidm approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after CI

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels May 11, 2023
@lidavidm
Copy link
Member

Ah, CI is not happy since the imports have to be sorted

lidavidm
lidavidm approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 1624d5a into apache:main May 12, 2023
@ursabot
Copy link

ursabot commented May 13, 2023

Benchmark runs are scheduled for baseline = cdefbb8 and contender = 1624d5a. 1624d5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.44% ⬆️0.03%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1624d5aa ec2-t3-xlarge-us-east-2
[Finished] 1624d5aa test-mac-arm
[Finished] 1624d5aa ursa-i9-9960x
[Finished] 1624d5aa ursa-thinkcentre-m75q
[Finished] cdefbb8f ec2-t3-xlarge-us-east-2
[Finished] cdefbb8f test-mac-arm
[Finished] cdefbb8f ursa-i9-9960x
[Finished] cdefbb8f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 13, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@wenxlan @ArgusLi
apacheGH-35528:[Java] Fix RangeEqualsVisitor comparing BitVector with…
4892a4e 
… different begin index (apache#35525)

### Rationale for this change

bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. 

In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it.

### What changes are included in this PR?

only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test

### Are these changes tested?
yes.

### Are there any user-facing changes?
no.

* Closes: apache#35528

Authored-by: wenxianglan.233 <[email protected]>
Signed-off-by: David Li <[email protected]>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@wenxlan @rtpsw
apacheGH-35528:[Java] Fix RangeEqualsVisitor comparing BitVector with…
f3610a8 
… different begin index (apache#35525)

### Rationale for this change

bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. 

In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it.

### What changes are included in this PR?

only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test

### Are these changes tested?
yes.

### Are there any user-facing changes?
no.

* Closes: apache#35528

Authored-by: wenxianglan.233 <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java]bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index.
3 participants
@wenxlan @lidavidm @ursabot