Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34731: [Python] Release GIL when creating RecordBatchReader #34732

Merged
merged 1 commit into from
Mar 27, 2023
Merged

GH-34731: [Python] Release GIL when creating RecordBatchReader #34732

merged 1 commit into from
Mar 27, 2023

Conversation

lupko
Copy link
Contributor

@lupko lupko commented Mar 26, 2023 •
edited
Loading

Rationale for this change

See #34731

What changes are included in this PR?

Wrap existing call that creates RBR in with nogil: context

Are these changes tested?

No new tests.

Are there any user-facing changes?

No

@lupko lupko requested a review from lidavidm as a code owner March 26, 2023 12:18
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #34731 has been automatically assigned in GitHub to PR creator.

lidavidm
lidavidm approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 27, 2023
@lidavidm
Copy link
Member

Failure is #34743

@lidavidm lidavidm merged commit 8d1863a into apache:main Mar 27, 2023
@ursabot
Copy link

ursabot commented Mar 27, 2023

Benchmark runs are scheduled for baseline = eaa1a1e and contender = 8d1863a. 8d1863a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.39% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8d1863a7 ec2-t3-xlarge-us-east-2
[Failed] 8d1863a7 test-mac-arm
[Finished] 8d1863a7 ursa-i9-9960x
[Finished] 8d1863a7 ursa-thinkcentre-m75q
[Finished] eaa1a1ea ec2-t3-xlarge-us-east-2
[Failed] eaa1a1ea test-mac-arm
[Finished] eaa1a1ea ursa-i9-9960x
[Failed] eaa1a1ea ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@lupko @ArgusLi
apacheGH-34731: [Python] Release GIL when creating RecordBatchReader (a…
ad32a64 
…pache#34732)

### Rationale for this change

See apache#34731

### What changes are included in this PR?

Wrap existing call that creates RBR in `with nogil:` context

### Are these changes tested?

No new tests. 

### Are there any user-facing changes?

No

* Closes: apache#34731

Authored-by: lupko <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: FlightRPC Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] MetadataRecordBatchReader does not release GIL in to_reader() method
3 participants
@lupko @lidavidm @ursabot