Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Use hyphen-separated words for error tag #45390

Closed
hiroyuki-sato opened this issue Jan 30, 2025 · 1 comment
Closed

[GLib] Use hyphen-separated words for error tag #45390

hiroyuki-sato opened this issue Jan 30, 2025 · 1 comment
Assignees
@hiroyuki-sato
Labels
Component: GLib Type: bug
Milestone
20.0.0

Comments

@hiroyuki-sato
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

#44758 implemented garrow_array_validate_full(). But it contained typo. the message validate_full should be validate-full.

Component(s)

GLib
hiroyuki-sato added a commit to hiroyuki-sato/arrow that referenced this issue Jan 30, 2025
@hiroyuki-sato
apacheGH-45390: [GLib] Fix typo. validate_full -> validate-full
ac1a908
@hiroyuki-sato hiroyuki-sato mentioned this issue Jan 30, 2025
Merged
@kou kou changed the title [GLib] Fix typo. validate_full -> validate-full [GLib] Use hyphen-separated words for error tag Jan 30, 2025
kou pushed a commit that referenced this issue Jan 30, 2025
@hiroyuki-sato
GH-45390: [GLib] Use hyphen-separated words for error tag (#45391)
73b8812 
### Rationale for this change

#45390 implemented `garrow_array_validate_full()`. But it used `validate_full` not `validate-full` for error tag. We should use hyphen-separated words for error tag for consistency.

### What changes are included in this PR?

`validate_ful` -> `validate-full`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* GitHub Issue: #45390

Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 20.0.0 milestone Jan 30, 2025
@kou
Copy link
Member

kou commented Jan 30, 2025

Issue resolved by pull request 45391
#45391

@kou kou closed this as completed Jan 30, 2025
lriggs pushed a commit to lriggs/arrow that referenced this issue Jan 30, 2025
@hiroyuki-sato @lriggs
apacheGH-45390: [GLib] Use hyphen-separated words for error tag (apac…
a081ba7 
…he#45391)

### Rationale for this change

apache#45390 implemented `garrow_array_validate_full()`. But it used `validate_full` not `validate-full` for error tag. We should use hyphen-separated words for error tag for consistency.

### What changes are included in this PR?

`validate_ful` -> `validate-full`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* GitHub Issue: apache#45390

Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiroyuki-sato hiroyuki-sato

Labels
Component: GLib Type: bug
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@kou @hiroyuki-sato