Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] R CMD check failure with dev testthat #44674

Closed
hadley opened this issue Nov 7, 2024 · 4 comments · Fixed by #44675
Closed

[R] R CMD check failure with dev testthat #44674

hadley opened this issue Nov 7, 2024 · 4 comments · Fixed by #44675
Assignees
Milestone

Comments

@hadley
Copy link
Contributor

hadley commented Nov 7, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Five arrow tests fail with the dev version of testthat:

── Failure ('test-Array.R:1264:3'): concat_arrays works ────────────────────────
all(concat_int == arrow_array(1:5)) is not TRUE

`actual` is an R6 object of class <Scalar/ArrowDatum/ArrowObject>
`expected` is a logical vector (TRUE)
── Failure ('test-Array.R:1272:3'): concat_arrays works ────────────────────────
all(concat_int == arrow_array(1:5)) is not TRUE

`actual` is an R6 object of class <Scalar/ArrowDatum/ArrowObject>
`expected` is a logical vector (TRUE)
── Failure ('test-Array.R:1286:3'): concat_arrays() coerces its input to Array ──
all(concat_ints == arrow_array(c(1L, 2L))) is not TRUE

`actual` is an R6 object of class <Scalar/ArrowDatum/ArrowObject>
`expected` is a logical vector (TRUE)
── Failure ('test-extension.R:38:3'): extension types can be created ───────────
all(array$storage() == storage) is not TRUE

`actual` is an R6 object of class <Scalar/ArrowDatum/ArrowObject>
`expected` is a logical vector (TRUE)
── Failure ('test-parquet.R:458:3'): deprecated int96 timestamp unit can be specified when reading Parquet files ──
result$some_datetime == table$some_datetime is not TRUE

`actual` is an R6 object of class <ChunkedArray/ArrowDatum/ArrowObject>
`expected` is a logical vector (TRUE)

This is because expect_true() no longer coerces it's input to a vector (which was arguably a bug in the first place).

Component(s)

R

@amoeba amoeba self-assigned this Nov 7, 2024
@amoeba amoeba changed the title R CMD check failure with dev testthat [R] R CMD check failure with dev testthat Nov 7, 2024
@amoeba amoeba added this to the 18.1.0 milestone Nov 7, 2024
@amoeba
Copy link
Member

amoeba commented Nov 7, 2024

Thanks @hadley. I put up a PR to fix this, #44675, and put this issue in the 18.1.0 milestone so it'll get included in our upcoming submission to CRAN.

@hadley
Copy link
Contributor Author

hadley commented Nov 7, 2024

Awesome, thanks! I'm planning to submit to CRAN on Nov 11, and you'll then have three weeks to get a fix to CRAN. Is that enough time for y'all?

@amoeba
Copy link
Member

amoeba commented Nov 7, 2024

I think so. We've already done the prep work for our next CRAN submission so, while we'll have to re-run it all once more, I think we can do it all within that timeline. Thanks for checking.

@amoeba
Copy link
Member

amoeba commented Nov 8, 2024

Issue resolved by pull request 44675
#44675

amoeba added a commit that referenced this issue Nov 11, 2024
### Rationale for this change

Update assertion code in some of the R tests to be compatible with the in-development version of testthat.

### What changes are included in this PR?

Updated assertions in tests.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

Fixes #44674.
* GitHub Issue: #44674

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants