-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] R CMD check failure with dev testthat #44674
Comments
Thanks @hadley. I put up a PR to fix this, #44675, and put this issue in the 18.1.0 milestone so it'll get included in our upcoming submission to CRAN. |
Awesome, thanks! I'm planning to submit to CRAN on Nov 11, and you'll then have three weeks to get a fix to CRAN. Is that enough time for y'all? |
I think so. We've already done the prep work for our next CRAN submission so, while we'll have to re-run it all once more, I think we can do it all within that timeline. Thanks for checking. |
Issue resolved by pull request 44675 |
### Rationale for this change Update assertion code in some of the R tests to be compatible with the in-development version of testthat. ### What changes are included in this PR? Updated assertions in tests. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Fixes #44674. * GitHub Issue: #44674 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
Describe the bug, including details regarding any error messages, version, and platform.
Five arrow tests fail with the dev version of testthat:
This is because
expect_true()
no longer coerces it's input to a vector (which was arguably a bug in the first place).Component(s)
R
The text was updated successfully, but these errors were encountered: