Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add support for JDK version cross testing #43380

Closed
Tracked by #68
laurentgo opened this issue Jul 23, 2024 · 1 comment
Closed
Tracked by #68

[Java] Add support for JDK version cross testing #43380

laurentgo opened this issue Jul 23, 2024 · 1 comment
Assignees
@laurentgo
Labels
Component: Java Type: enhancement
Milestone
18.0.0

Comments

@laurentgo
Copy link
Contributor

Describe the enhancement requested

Upgrade Java version used by toolchain to Java 21 or latest enhancement would require the ability to specify a different JDK version to be used for tests in order to retain the ability to validate Arrow against multiple Java versions.

To achieve this, Maven toolchains support for surefire/failsafe plugins can be used. This can be then be controlled by a build property.

Component(s)

Java
@laurentgo laurentgo mentioned this issue Jul 23, 2024
Open
2 tasks
laurentgo added a commit to laurentgo/arrow that referenced this issue Jul 23, 2024
@laurentgo
apacheGH-43380: [Java] Add support for cross jdk version testing
5c1dd11 
Provided a new property `arrow.test.jdk-version` which specify a JDK
version to be used by surefire/failsafe plugins instead of the version
used to execute Maven.

As part of the change, also add a Java version for TestOpens to only be
executed if Java runtime version is 16 or greater

Also add a Testing section to the Java developer documentation
@github-actions github-actions bot mentioned this issue Jul 23, 2024
Merged
danepitkin added a commit that referenced this issue Jul 25, 2024
@laurentgo @lidavidm @danepitkin
GH-43380: [Java] Add support for cross jdk version testing (#43381)
fc075ad 
### Rationale for this change

This change allows to use a different JDK version for tests than the one used to build the project.

### What changes are included in this PR?

Provided a new property `arrow.test.jdk-version` which specify a JDK version to be used by surefire/failsafe plugins instead of the version used to execute Maven.

As part of the change, also add a Java version for `TestOpens` to only be executed if Java runtime version is 16 or greater

Also add a Testing section to the Java developer documentation

### Are these changes tested?

via CI/CD

### Are there any user-facing changes?

New build property `arrow.test.jdk-version` allows developers to specify the JDK version used for tests

* GitHub Issue: #43380

Lead-authored-by: Laurent Goujon <[email protected]>
Co-authored-by: Laurent Goujon <[email protected]>
Co-authored-by: David Li <[email protected]>
Co-authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Dane Pitkin <[email protected]>
@danepitkin danepitkin added this to the 18.0.0 milestone Jul 25, 2024
@danepitkin
Copy link
Member

Issue resolved by pull request 43381
#43381

@laurentgo laurentgo mentioned this issue Jul 30, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@laurentgo @danepitkin