[C#][Integration] Integration CI job is still failing for C# consumers #41263
Comments
CurtHagenlocher
pushed a commit
that referenced
this issue
Apr 19, 2024
…es of the bitmap comparison (#41264) ### Rationale for this change The optimization for validity buffers was still failing after #41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: #41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
|
Issue resolved by pull request 41264 |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 2, 2024
…branches of the bitmap comparison (apache#41264) ### Rationale for this change The optimization for validity buffers was still failing after apache#41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: apache#41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 4, 2024
…branches of the bitmap comparison (apache#41264) ### Rationale for this change The optimization for validity buffers was still failing after apache#41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: apache#41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this issue
May 8, 2024
…branches of the bitmap comparison (apache#41264) ### Rationale for this change The optimization for validity buffers was still failing after apache#41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: apache#41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this issue
May 8, 2024
…branches of the bitmap comparison (apache#41264) ### Rationale for this change The optimization for validity buffers was still failing after apache#41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: apache#41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
…branches of the bitmap comparison (apache#41264) ### Rationale for this change The optimization for validity buffers was still failing after apache#41259 (sorry!). ### What changes are included in this PR? There were still two problems: - The offset of the actual array was not considered in the "optimized" branch - When this offset *was* considered, it became clear that zero-length arrays were not going to work in that branch ### Are these changes tested? I added the integration workflow to also run for C# additions. This might be a heavy CI job and I'm not sure if you want to keep it there (but running it is useful for this PR to ensure I actually fix things). For future me (or maybe future others), the integration tests are pretty easy to check: ``` dotnet build archery integration --run-c-data --with-csharp=true ``` ### Are there any user-facing changes? No. * GitHub Issue: apache#41263 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Sorry for the spam with these...I didn't check the full integration CI job before merging #41259 😬 . PR incoming! There are still issues:
https://github.com/apache/arrow/actions/runs/8725386715/job/23938224643
Component(s)
C#, Integration
The text was updated successfully, but these errors were encountered: