ARROW-17966: Prefer range loops where possible

apache · Oct 20, 2022 · 26fd452 · 26fd452
1 parent 59997e0
commit 26fd452
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cpp/src/arrow/engine/substrait/expression_internal.cc b/cpp/src/arrow/engine/substrait/expression_internal.cc
@@ -83,8 +83,8 @@ Status DecodeOption(const substrait::FunctionOption& opt, SubstraitCall* call) {
     return Status::Invalid("Invalid Substrait plan.  The option ", opt.name(),
                            " is specified but does not list any choices");
   }
-  for (int i = 0; i < opt.preference_size(); i++) {
-    prefs.push_back(opt.preference(i));
+  for (const auto& preference : opt.preference()) {
+    prefs.push_back(preference);
   }
   call->SetOption(opt.name(), prefs);
   return Status::OK();
@@ -100,8 +100,8 @@ Result<SubstraitCall> DecodeScalarFunction(
     ARROW_RETURN_NOT_OK(DecodeArg(scalar_fn.arguments(i), static_cast<uint32_t>(i), &call,
                                   ext_set, conversion_options));
   }
-  for (int i = 0; i < scalar_fn.options_size(); i++) {
-    ARROW_RETURN_NOT_OK(DecodeOption(scalar_fn.options(i), &call));
+  for (const auto& opt : scalar_fn.options()) {
+    ARROW_RETURN_NOT_OK(DecodeOption(opt, &call));
   }
   return std::move(call);
 }