Hide implicit optional dependency features in arrow-flight #6806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dependency X marked `optional = true` implicitly defines a feature X. Docs: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies This can be seen at https://docs.rs/crate/arrow-flight/53.3.0/features The optional dependencies were not meant to be standalone features though. Using `dep:` in the `[features]` section is supposed to disable this. It is enough to use `dep:` once. It's used for every optional dependency for consistency.
github-actions
bot
added
arrow
mbrobbel
approved these changes
Nov 26, 2024
findepi
deleted the
findepi/hide-implicit-optional-dependency-features-in-arrow-flight-b66a81
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None but was found when working on #6796 / #6804
Rationale for this change
A dependency X marked
optional = trueimplicitly defines a feature X. Docs: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies This can be seen at https://docs.rs/crate/arrow-flight/53.3.0/featuresThe optional dependencies were not meant to be standalone features though. Using
dep:in the[features]section is supposed to disable this. It is enough to usedep:once. It's used for every optional dependency for consistency.What changes are included in this PR?
Are there any user-facing changes?
yes
cc @alamb