Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APIs deprecated since v 4.4.0 #6722

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 12, 2024

Which issue does this PR close?

None

Rationale for this change

The deprecated APIs are not supposed to stay around for ever. The purpose of deprecation is to eventually remove.

What changes are included in this PR?

Remove flight_schema_from_arrow_schema, flight_data_from_arrow_schema, ipc_message_from_arrow_schema, that were deprecated for about three and a half years.

Are there any user-facing changes?

yes

The deprecated APIs are not supposed to stay around for ever. The
purpose of deprecation is to eventually remove.
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Nov 12, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi for the cleanup work.

@tustvold tustvold added api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version labels Nov 12, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi

@alamb
Copy link
Contributor

alamb commented Nov 21, 2024

Main is open for breaking changes now that 53.3.0 has been released so 🚀

@alamb alamb merged commit cc4bd46 into apache:master Nov 21, 2024
12 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 21, 2024

Thanks again @findepi

@findepi findepi deleted the findepi/remove-apis-deprecated-since-v-4-4-0-b37f46 branch November 21, 2024 14:42
@findepi
Copy link
Member Author

findepi commented Nov 22, 2024

thanks for the merge!

Main is open for breaking changes now that 53.3.0 has been released so 🚀

is #6609 good to go too?

or any other flagged with api-change label api-change Changes to the arrow API ?

@alamb
Copy link
Contributor

alamb commented Nov 22, 2024

Yup -- I just haven't had a chance to move them along. I plan to devote some time this afternoon to moving arrow-rs along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate next-major-release the PR has API changes and it waiting on the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants