-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable TLS roots for flight CLI client #6640
fix: enable TLS roots for flight CLI client #6640
Conversation
Otherwise you get: ```text Error: setup client Caused by: 0: connect to endpoint 1: transport error 2: invalid peer certificate: UnknownIssuer 3: invalid peer certificate: UnknownIssuer ``` Also see hyperium/tonic#1904 .
Ideally we'd have a test of this, but I don't feel strongly and it is probably difficult to setup |
I thought about that, but that would require that we have a server that has a certificate that is accepted by the Mozilla CA bundle, so without additional infrastructure, I don't think that's feasible. Or we do something "stupid" like point the client to |
That sounds like it could very well end up being flaky, I think let's leave it for now and we can always revisit |
This reverts commit 2983dc1.
This reverts commit 2983dc1.
This reverts commit 2983dc1.
This reverts commit 2983dc1.
Which issue does this PR close?
-
Rationale for this change
Otherwise you get:
Also see hyperium/tonic#1904 .
What changes are included in this PR?
Just call the method that registers the roots that we include via feature flags anyways.
Are there any user-facing changes?
TLS works again.