Clarify interval comparison behavior with documentation and tests #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/interval_clarification
branch
from
3197fc4 to
4361eef
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #5180
Rationale for this change
I was quite confused by the discussion on #5180. My final understanding is that the confusion stems from the fact that when different people "interval comparison" they may mean different things.
Given the subtleness of this topic and potential for confusion, I would like to avoid future confusion by better documenting the behavior of interval comparisons in the arrow crate so the intent is clear.
What changes are included in this PR?
Intervaltypes are compared and explaining the behavior of interval comparisonsAre there any user-facing changes?
More docs