Add FFI from_raw #5082
Merged
Add FFI from_raw #5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
add-ffi-from-raw
branch
from
468807b to
9bdecc4
Compare
pitrou
approved these changes
Nov 16, 2023
tustvold
commented
Nov 16, 2023
| /// [move]: https://arrow.apache.org/docs/format/CDataInterface.html#moving-an-array | ||
| /// [valid]: https://doc.rust-lang.org/std/ptr/index.html#safety | ||
| pub unsafe fn from_raw(array: *mut FFI_ArrowArray) -> Self { | ||
| std::ptr::replace(array, Self::empty()) |
There was a problem hiding this comment.
Something that occurs to me is we don't verify that release isn't NULL, as it can't be an invariant that FFI_ArrowArray doesn't have a null release callback for obvious reasons, but then the accessors assume the data is valid. Perhaps we should be asserting that FFI_ArrowArray hasn't been released in the accessors?
The good news is I don't think you can hit this with safe code, but it is potentially interesting
There was a problem hiding this comment.
Asserting that the release pointer isn't NULL sounds good to me.
wjones127
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This makes it easier to correctly move data across FFI boundaries
What changes are included in this PR?
Are there any user-facing changes?