Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup more uses of Array::data (#3880) #4002

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Cleanup more uses of Array::data (#3880) #4002

merged 8 commits into from
Apr 3, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Apr 2, 2023

Which issue does this PR close?

Part of #3880

Rationale for this change

Continues the process of removing uses of Array::data in anticipation of deprecating it

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Apr 2, 2023
@tustvold tustvold force-pushed the cleanup-uses-of-array-data2 branch from 8c4d3e0 to 7ab45fb Compare April 3, 2023 09:50
crepererum
crepererum approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I'm wondering (for my personal knowledge base): what's the difference of to_data() and into_data()?

@tustvold
Copy link
Contributor Author

tustvold commented Apr 3, 2023

what's the difference of to_data() and into_data()?

to_data takes &self, whereas into_data takes self

@crepererum
Copy link
Contributor

In case anybody else runs into this question:

image

@tustvold tustvold merged commit d7bba0a into apache:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crepererum crepererum crepererum approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tustvold @crepererum